Skip to content

Mssing peer deps for wrong package #8323

Closed

Description

@julien-hml

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

9.5.0

Which area(s) of pnpm are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue or a replay of the bug

https://github.com/zweird-958/my-wishlist/

Reproduction steps

Go on branch chore/eslint and do pnpm i

Describe the Bug

I need to install @types/node whereas ts-node isn't installed.
image

It's installed only on packages/db

Expected Behavior

Avoid to have this warning

Which Node.js version are you using?

20.9.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

Activity

  1. self-assigned this
    on Jul 22, 2024
  2. zkochan commented on Jul 22, 2024

    @zkochan
    Member

    Actually, the bug here is that @types/node wasn't automatically installed.

    If you don't want ts-node (and other peers) automatically installed, set auto-install-peers to false in your .npmrc.

  3. added a commit that references this issue on Jul 23, 2024
    d5beff1
  4. julien-hml commented on Jul 23, 2024

    @julien-hml
    Author

    Actually, the bug here is that @types/node wasn't automatically installed.

    If you don't want ts-node (and other peers) automatically installed, set auto-install-peers to false in your .npmrc.

    But tooling/tailwind doesn't use ts-node so why I have this warning ?

  5. zkochan commented on Jul 24, 2024

    @zkochan
    Member

    One of the dependencies of tailwindcss has ts-node in peer dependencies, so it gets installed because auto-install-peers is set to true by default.

  6. julien-hml commented on Jul 24, 2024

    @julien-hml
    Author

    One of the dependencies of tailwindcss has ts-node in peer dependencies, so it gets installed because auto-install-peers is set to true by default.

    I don't find any peer dependencies in tailwindcss https://www.npmjs.com/package/tailwindcss?activeTab=code

    Also I have ts-node in packages/db and if I remove from it. I doesn't have the warning on tooling/tailwind.

    I don't think is that...

  7. kenrick95 commented on Jul 24, 2024

    @kenrick95
    Member

    I don't find any peer dependencies in tailwindcss

    • tailwindcss depends on postcss-load-config
    • postcss-load-config has ts-node on its peerDependencies and it is marked as optional

    https://github.com/Zweird-958/my-wishlist/blob/bb2f6c7be502b02907e313cefc73c001c4c2337f/pnpm-lock.yaml#L5649

  8. julien-hml commented on Jul 24, 2024

    @julien-hml
    Author

    I don't find any peer dependencies in tailwindcss

    • tailwindcss depends on postcss-load-config
    • postcss-load-config has ts-node on its peerDependencies and it is marked as optional

    https://github.com/Zweird-958/my-wishlist/blob/bb2f6c7be502b02907e313cefc73c001c4c2337f/pnpm-lock.yaml#L5649

    Hmm thank you for your answer but I'm not sure is the issue.

    I deleted ts-node from packages/db and I don't have any warning

    image

    tooling/tailwind package.json:

    {
      "name": "@my-wishlist/tailwind",
      "version": "1.0.0",
      "type": "module",
      "main": "base.ts",
      "scripts": {
        "test": "echo \"Error: no test specified\" && exit 1",
        "typecheck": "tsc --noEmit",
        "lint": "eslint"
      },
      "keywords": [],
      "author": "",
      "license": "ISC",
      "dependencies": {
        "autoprefixer": "^10.4.19",
        "postcss": "^8.4.39",
        "tailwindcss": "catalog:"
      },
      "devDependencies": {
        "eslint": "catalog:",
        "@my-wishlist/eslint": "workspace:*",
        "@my-wishlist/typescript": "workspace:*",
        "typescript": "catalog:"
      }
    }
  9. added a commit that references this issue on Jul 25, 2024
    9682129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions