BLD: load extra flags when checking for libflame#19671
Merged
charris merged 1 commit intonumpy:maintenance/1.21.xfrom Aug 14, 2021
Merged
BLD: load extra flags when checking for libflame#19671charris merged 1 commit intonumpy:maintenance/1.21.xfrom
charris merged 1 commit intonumpy:maintenance/1.21.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #19582.
When trying to build numpy with a locally compiled libflame, it fails in
calc_info()(here) when callingcheck_embedded_lapack(), if the library needs additional flags when compiling / linking. In this function, when callingextra_args = info.get('extra_link_args', [])(here), it returns an empty list, even if arguments are provided insite.cfg, as stated in the example configuration file. This pull request loads the extra arguments, before trying to compile.