MAINT: Relax certain integer-type constraints#18887
Merged
charris merged 6 commits intonumpy:maintenance/1.20.xfrom May 3, 2021
Merged
MAINT: Relax certain integer-type constraints#18887charris merged 6 commits intonumpy:maintenance/1.20.xfrom
charris merged 6 commits intonumpy:maintenance/1.20.xfrom
Conversation
added 5 commits
May 2, 2021 21:41
Change `int` into the more forgiving `SupportsIndex` protocol
Mypy 0.790 does not yet contain annotations for `typing_extensions.SupportsIndex`, so we'll have to define them ourselves
Member
|
Thanks Bas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18778 and #18800.
As was noted in scipy/scipy#13833 (comment) the definition of
npt._ShapeLike(and certain integer-relatedtypes in general) were to strict prior to aforementioned backports.
The latter currently demands a
builtins.int(or a sequence thereof) while the likes ofnp.integeror,more generally, objects implementing the
__index__protocol are generally suitable alternatives.