Hm, anyone knows why only PyPy cannot seem to find the new numpy.typing.mypy_plugin module (test)?

EDIT: Found the issue (f21c8f6).

Interesting, tricky puzzle to get the details of this typing right. I'm not sure if one approach is clearly preferable to the other.

The mypy plugin may possibly be slightly more robust to situations like cross-compiling (e.g. there's an open PR for ARM64 build on Windows, which may get the intp size wrong). However those are pretty niche cases that likely won't matter at all in practice.

On the other hand, the plugin approach will require the user to add it in their own mypy.ini as well as have some runtime overhead (any idea how much?).

On the other hand, the plugin approach will require the user to add it in their own mypy.ini as well as have some runtime overhead (any idea how much?).

The runtime overhead should still be zero, as the new numpy.typing.mypy_plugin module should generally only be imported by mypy itself (so during static type checking). There are a couple of contingencies inside the module to ensure that it can always be imported during runtime, but this is moreso because the numpy tests require it to be so (regardless of what optional dependencies are present or not).

The runtime overhead should still be zero, as the new numpy.typing.mypy_plugin module should generally only be imported by mypy itself (so during static type checking).

Yeah I get that - I meant runtime of mypy (which can be slow).

Yeah I get that - I meant runtime of mypy (which can be slow).

Ah right, when running mypy on the script below I'm observing a minor increase in runtime when initially generating the mypy cache (~7.4 vs ~7.8 sec). Once the cache has been generated the difference disappears in its entirety though (~0.4 sec in both cases).

import numpy as np

Needs rebase.

Needs rebase.

Yup, I'm planning on adding the release note + rebase later this evening.

Alright, the branch has been rebased and a release note (5c7c22a) has been added.

This accumulated another merge conflict unfortunately.

Give me a sec.

And the conflict has been resolved.