Skip to content

fix(core): remove check for taskGraph equality - #17862

Merged
FrozenPandaz merged 1 commit into
nrwl:masterfrom
Cammisuli:fix_task_hash_cache
Jun 29, 2023
Merged

FrozenPandaz merged 1 commit into
nrwl:masterfrom
Cammisuli:fix_task_hash_cache

Conversation

@Cammisuli

@Cammisuli Cammisuli commented Jun 29, 2023 •

Copy link
Copy Markdown
Member

Current Behavior

When ever the daemon tries to hash tasks, there is a check to see if the taskGraph is different from the stored one. This will always be false because the taskGraph is always going to be a new object from the payload

Expected Behavior

Removing the taskGraph equality check allows the taskhasher to be properly cached

Related Issue(s)

Fixes #

@Cammisuli
Cammisuli requested a review from a team as a code owner June 29, 2023 14:45
@Cammisuli
Cammisuli requested a review from AgentEnder June 29, 2023 14:45
@vercel

vercel Bot commented Jun 29, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 2:49pm

@nx-cloud

nx-cloud Bot commented Jun 29, 2023 •

Copy link
Copy Markdown
Contributor

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 16f8e81. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions

github-actions Bot commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 5, 2023

This branch was successfully deployed

1 active deployment
Preview — 16f8e81c Deployed Jun 29, 2023 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants