Skip to content

Add Java 21 to CI build matrix#3145

Merged
TimvdLippe merged 1 commit intomockito:mainfrom
valfirst:ci-java-21
Oct 18, 2023
Merged

Add Java 21 to CI build matrix#3145
TimvdLippe merged 1 commit intomockito:mainfrom
valfirst:ci-java-21

Conversation

@valfirst
Copy link
Copy Markdown
Contributor

@valfirst valfirst commented Oct 16, 2023

Add Java 21 (LTS) to CI build matrix

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9f06733) 85.51% compared to head (88e7b68) 85.53%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3145      +/-   ##
============================================
+ Coverage     85.51%   85.53%   +0.01%     
- Complexity     2908     2912       +4     
============================================
  Files           333      333              
  Lines          8852     8856       +4     
  Branches       1095     1095              
============================================
+ Hits           7570     7575       +5     
+ Misses          994      993       -1     
  Partials        288      288
Files Coverage Δ
src/main/java/org/mockito/ArgumentCaptor.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valfirst
Copy link
Copy Markdown
Contributor Author

valfirst commented Oct 16, 2023 •
edited
Loading

Blocked by #3147

@TimvdLippe
Copy link
Copy Markdown
Contributor

TimvdLippe commented Oct 18, 2023

Seems like CodeCov is having some issues 😢

@TimvdLippe
Copy link
Copy Markdown
Contributor

TimvdLippe commented Oct 18, 2023

Seems like the upload token doesn't work on PRs: codecov/feedback#126

@valfirst valfirst force-pushed the ci-java-21 branch 6 times, most recently from 548fad4 to c5fa5f1 Compare October 18, 2023 15:43
@valfirst
Copy link
Copy Markdown
Contributor Author

valfirst commented Oct 18, 2023

@TimvdLippe it seems Android 33 job is flaky

@TimvdLippe
Copy link
Copy Markdown
Contributor

TimvdLippe commented Oct 18, 2023

Yeah unfortunately it is 😢 But the rest works, so let's merge this. Thanks for the work!

@TimvdLippe TimvdLippe merged commit 9342e9a into mockito:main Oct 18, 2023
@valfirst valfirst deleted the ci-java-21 branch October 18, 2023 20:24
This was referenced Nov 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valfirst @codecov-commenter @TimvdLippe