Fixes 2933: IOUtils does not depend on platform encoding any more#2935
Merged
TimvdLippe merged 1 commit intomockito:mainfrom Mar 9, 2023
Merged
Fixes 2933: IOUtils does not depend on platform encoding any more#2935TimvdLippe merged 1 commit intomockito:mainfrom
TimvdLippe merged 1 commit intomockito:mainfrom
Conversation
…t uses UTF-8 instead
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
=========================================
Coverage 85.65% 85.65%
Complexity 2847 2847
=========================================
Files 325 325
Lines 8623 8623
Branches 1060 1060
=========================================
Hits 7386 7386
Misses 964 964
Partials 273 273
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem that occured on platforms that had non-ASCII-based default encodings: #2933
I tested it on IBM z/OS and the problem mentioned in the issue with garbled class names disappeared. Sadly, it still doesn't fully work, but that's probably an unrelated problem, perhaps #801
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant