Conversation
…d but an unmocked subclass is initiated.
f28941a to
02615ff
Compare
Codecov Report
@@ Coverage Diff @@
## main #2682 +/- ##
=========================================
Coverage 86.26% 86.26%
- Complexity 2779 2791 +12
=========================================
Files 315 317 +2
Lines 8334 8394 +60
Branches 1035 1048 +13
=========================================
+ Hits 7189 7241 +52
- Misses 874 880 +6
- Partials 271 273 +2
Continue to review full report at Codecov.
|
TimvdLippe
reviewed
Jun 12, 2022
Contributor
TimvdLippe
left a comment
There was a problem hiding this comment.
Nice fix! Do you know what the performance impact on this is? Can we cache the result (I am assuming not)?
Also, can we cover a bit more of the code or is this mostly it?
Contributor
|
@raphw shall we merge this one? |
Member
Author
|
Yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2680. Offers two implementations, one using a regular stack trace processor, one using StackWalker which is more accurate but requires a VM using Java 9 or newer.