Localize shell variable REPLY to avoid overwriting users' value#489
Merged
kislyuk merged 1 commit intokislyuk:developfrom Jun 12, 2024
Merged
Localize shell variable REPLY to avoid overwriting users' value#489kislyuk merged 1 commit intokislyuk:developfrom
kislyuk merged 1 commit intokislyuk:developfrom
Conversation
Owner
|
Thanks! |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell function
__python_argcomplete_scan_headin the completion setting (argcomplete/bash_completion.d/_python-argcomplete) uses thereadbuiltin without specifying variable names. This stores thereadresult in the shell variableREPLY. Then,__python_argcomplete_scan_headchecks the value ofREPLY. A problem is that this will clobber the users' values of the global shell variableREPLYon an attempt of completion. We should declare theREPLYas a local variable in the shell function__python_argcomplete_scan_head.