fix(item): router-link remains clickable with item cover#29743
Merged
brandyscarney merged 1 commit intomainfrom Aug 5, 2024
Merged
fix(item): router-link remains clickable with item cover#29743brandyscarney merged 1 commit intomainfrom
brandyscarney merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
approved these changes
Aug 1, 2024
Contributor
|
Subject line could be: |
This was referenced Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Item includes
ion-anchorin the list of clickable components it queries. This component was renamed toion-router-linkin v5.What is the new behavior?
Updates the reference to
ion-anchortoion-router-linkinion-item.Does this introduce a breaking change?