Skip to content

fix(item): router-link remains clickable with item cover#29743

Merged
brandyscarney merged 1 commit intomainfrom
fix-item-anchor
Aug 5, 2024
Merged

fix(item): router-link remains clickable with item cover#29743
brandyscarney merged 1 commit intomainfrom
fix-item-anchor

Conversation

@brandyscarney
Copy link
Copy Markdown
Member

Issue number: N/A


What is the current behavior?

Item includes ion-anchor in the list of clickable components it queries. This component was renamed to ion-router-link in v5.

What is the new behavior?

Updates the reference to ion-anchor to ion-router-link in ion-item.

Does this introduce a breaking change?

  • Yes
  • No

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 9:07pm

@brandyscarney brandyscarney marked this pull request as ready for review July 31, 2024 21:07
@brandyscarney brandyscarney requested a review from a team as a code owner July 31, 2024 21:07
@github-actions github-actions Bot added the package: core @ionic/core package label Jul 31, 2024
@sean-perkins
Copy link
Copy Markdown
Contributor

Subject line could be: fix(item): router-link stays clickable with item cover or similar.

@brandyscarney brandyscarney changed the title fix(item): check for ion-router-link instead of ion-anchor fix(item): router-link remains clickable with item cover Aug 1, 2024
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants