googleapis: Allow user set c2p bootstrap config#9856
Merged
temawi merged 3 commits intogrpc:masterfrom Jan 24, 2023
Merged
Conversation
Instead of always overriding the bootstrap with a custom c2p config, now we allow user defined ones to also be used. This only applies when running in GCP with federation.
Contributor
Author
|
@apolcyn Could you please check that this meets the requirements? @easwars Can you spot any discrepancies with the Go implementation? @YifeiZhuang Can you please sanity check my approach of omitting the setting of the bootstrap override to allow xds client to pick up a user provided config? |
apolcyn
reviewed
Jan 24, 2023
Contributor
apolcyn
left a comment
There was a problem hiding this comment.
This looks correct to me.
Suggesting one simplifying change, though.
Also some refactoring for code clarity.
apolcyn
approved these changes
Jan 24, 2023
YifeiZhuang
reviewed
Jan 24, 2023
YifeiZhuang
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always overriding the bootstrap with a custom c2p config, now we allow user defined ones to also be used. This only applies when running in GCP with federation.