Merged
Conversation
…ake downstream tasks cacheable
runningcode
reviewed
Jan 24, 2023
Contributor
runningcode
left a comment
There was a problem hiding this comment.
looks good. just one suggestion. we should give the property a name so that it is easier to see and track.
Co-authored-by: Nelson Osacky <nelson@osacky.com>
larry-safran
approved these changes
Feb 6, 2023
ejona86
approved these changes
Feb 6, 2023
Member
ejona86
left a comment
There was a problem hiding this comment.
Yeah, we don't care about cachability in our build at all. I don't trust the feature enough to use it for the CI, which is where it'd do us the most good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a pair of issues that prevent complete cacheability of certain tasks in the project's build:
build.gradlefile in such a way that the dependency is registered with the full absolute path of the project on the local node. This makes it impossible to cache those tasks between two nodes with a different directory layout. Fixed by specifying that the file path should be relative to the project dir.NettyResourceTransformerobject innetty/shaded/build.gradleis not explicitly marked as cacheable. This, I admit, I took more of a guess that it was an oversight, but if there's a reason, I can drop that from the PR.UPDATE:
These are the build scans that demonstrate the change:
You can clearly see here that tasks move "not cacheable" to "cacheable" as a result of this change.