xds: Disallow duplicate addresses in the RingHashLB.#9776
Merged
larry-safran merged 3 commits intogrpc:masterfrom Jan 3, 2023
Merged
xds: Disallow duplicate addresses in the RingHashLB.#9776larry-safran merged 3 commits intogrpc:masterfrom
larry-safran merged 3 commits intogrpc:masterfrom
Conversation
Removed test that was previously checking for specific expected behavior with duplicate addresses.
sergiitk
reviewed
Dec 28, 2022
sergiitk
approved these changes
Jan 3, 2023
Member
sergiitk
left a comment
There was a problem hiding this comment.
Good to go. Nits are totally optional.
sergiitk
approved these changes
Jan 3, 2023
Member
sergiitk
left a comment
There was a problem hiding this comment.
Thanks for addressing the nits!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag it as an error when the duplicate addresses are passed to acceptResolvedAddresses.
Removed test that was previously checking for specific expected behavior with duplicate addresses.