xds:Update logic to match A57#9745
Merged
larry-safran merged 5 commits intogrpc:masterfrom Dec 15, 2022
Merged
Conversation
…before creating the timer to mark resources absent.
…t haven't yet gotten results to match spec.
For some inexplicable reason the following call.verifyRequest fails only for the V2 test and only from command line not IDE unless there is some Thread.sleep, even if it is only 1-millis.
sanjaypujare
reviewed
Dec 9, 2022
Contributor
Author
|
@sanjaypujare Can you please re-review and approve? |
Contributor
Okay, will get to this once I am done with my current task |
Contributor
|
Added a few comments. Also I didn't find a test for "When the ads stream is closed only send errors to subscribers that haven't yet gotten results". It will be good to add a test for that too. |
Contributor
sanjaypujare
left a comment
There was a problem hiding this comment.
Made a few comments, once addressed will re-review
Contributor
Author
|
Comments addressed. Note that the feature you refer to is addressed by existing tests at 3211 and 3318. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update logic to match A57-xds-client-failure-mode-behavior.md