core: fix RejectedExecutionException in Retriable Stream#9626
Merged
YifeiZhuang merged 4 commits intogrpc:masterfrom Nov 22, 2022
Merged
core: fix RejectedExecutionException in Retriable Stream#9626YifeiZhuang merged 4 commits intogrpc:masterfrom
YifeiZhuang merged 4 commits intogrpc:masterfrom
Conversation
Member
Author
|
@ejona86 , do you want to approve? So that we can try import next monday. global tap seems fine. |
ejona86
reviewed
Nov 7, 2022
Member
ejona86
left a comment
There was a problem hiding this comment.
After changes for my two comments, the relationship with createSubstream()+inFlightSubStreams+callExecutor becomes more clear. We could end up moving the inFlightSubStreams increment to createSubstream() itself, maybe returning null if the increment fails.
ejona86
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #9547
revision 1
Add big negative integer to pending stream count when cancelled. The count is used to delay closing master listener until streams fully drained.
Increment pending stream count before creating one. The count is also used to indicate callExecutor is safe to be used. New stream not created if big negative number was added, i.e. stream cancelled. New stream is created if not cancelled, callExecutor is safe to be used, because cancel will be delayed.
revision 2
Integer.MIN_VALUE.