repositories.bzl: Use valid target name for grpc-services#9422
Merged
ejona86 merged 2 commits intogrpc:masterfrom Aug 2, 2022
Merged
repositories.bzl: Use valid target name for grpc-services#9422ejona86 merged 2 commits intogrpc:masterfrom
ejona86 merged 2 commits intogrpc:masterfrom
Conversation
This fixes builds including dependencies from Maven that use io.grpc:grpc-services. It resolves this error: ``` no such target '@io_grpc_grpc_java//services:services': target 'services' not declared in package 'services' defined by services/BUILD.bazel and referenced by '@maven//:io_grpc_grpc_services' ``` Fixes grpc#9419
sanjaypujare
reviewed
Aug 2, 2022
sanjaypujare
approved these changes
Aug 2, 2022
Contributor
sanjaypujare
left a comment
There was a problem hiding this comment.
LG
Added a comment about xds also needing a similar change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes builds including dependencies from Maven that use
io.grpc:grpc-services. It resolves this error:
Fixes #9419
CC @xushaoxiao