xds: Fail RPCs with error details when resources are deleted#9337
Merged
ejona86 merged 1 commit intogrpc:masterfrom Jul 6, 2022
Merged
xds: Fail RPCs with error details when resources are deleted#9337ejona86 merged 1 commit intogrpc:masterfrom
ejona86 merged 1 commit intogrpc:masterfrom
Conversation
Previously if LDS/RDS were missing or improperly configured RPCs would fail with "UNAVAILABLE: NameResolver returned no usable address errors". That is very confusing and not helpful for debugging. Ideally we'd also include the node id in this error message, but that's a bit more involved and this is a huge improvement even without it. b/237539851
YifeiZhuang
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if LDS/RDS were missing or improperly configured RPCs would
fail with "UNAVAILABLE: NameResolver returned no usable address errors".
That is very confusing and not helpful for debugging.
Ideally we'd also include the node id in this error message, but that's
a bit more involved and this is a huge improvement even without it.
b/237539851