core: Always pass offload executor to CallCredentials#9313
Merged
larry-safran merged 1 commit intogrpc:masterfrom Jun 28, 2022
Merged
core: Always pass offload executor to CallCredentials#9313larry-safran merged 1 commit intogrpc:masterfrom
larry-safran merged 1 commit intogrpc:masterfrom
Conversation
…plyingTransportFactory, never use the executor from CallCredentials in this case
e2bf3d2 to
6e3ab5d
Compare
ejona86
approved these changes
Jun 28, 2022
Member
ejona86
left a comment
There was a problem hiding this comment.
We use the core: Always use ... syntax in commit titles/PRs, not [core].
I think the title of this one isn't accurate or is at least confusing. This has little to do with what executor is used in streams, as this is a parameter is passed to call credentials. How about core: Always pass offload executor to CallCredentials?
Member
s/CallCredentials/CallOptions/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously would use the executor provided in CallOptions if it was present. Now that executor is ignored.