Add security Policy for verifying signature using sha-256 hash#9305
Merged
ejona86 merged 13 commits intogrpc:masterfrom Jun 24, 2022
Merged
Add security Policy for verifying signature using sha-256 hash#9305ejona86 merged 13 commits intogrpc:masterfrom
ejona86 merged 13 commits intogrpc:masterfrom
Conversation
Add security Policy for verifying signature using sha-256 hash
precompute hash value to avoid compute hash multiple times
markb74
approved these changes
Jun 23, 2022
Contributor
markb74
left a comment
There was a problem hiding this comment.
Thanks, this looks good. I'm adding Eric as well to make sure I'm not missing anything wrt the Hashing class.
ejona86
approved these changes
Jun 23, 2022
function > predicate in doc comment
change colletion to list
…nd copy list to immutablelist
revert last change: collection > list, change immutable list to list and make copy of list.
ejona86
approved these changes
Jun 23, 2022
Member
ejona86
left a comment
There was a problem hiding this comment.
If the byte[]s get copied, then LGTM
Contributor
Author
deep copied byte[]s in latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.