netty: implement UdsNameResolver and UdsNettyChannelProvider#9113
netty: implement UdsNameResolver and UdsNettyChannelProvider#9113sanjaypujare merged 11 commits intogrpc:masterfrom
Conversation
When the scheme is "unix:" we get the UdsNettyChannelProvider to create a NettyChannelBuilder with DomainSocketAddress type and other related params needed for UDS sockets
and address review comments
|
Addressed comments and added an e2e test. PTAL |
|
addressed the remaining comments. PTAL |
|
@sanjaypujare, push the changes? |
|
It has shown up now! |
The commit is there now: for some reason there was a delay which is really unusual. |
ejona86
left a comment
There was a problem hiding this comment.
It seems there are still unresolved review comments. UdsNettyChannelProvider has a busted isAvailable. Dependencies should be referenced via libraries map.
ejona86
left a comment
There was a problem hiding this comment.
The Bazel build will need to be updated. If you run into problems with that, ping me.
|
|
||
| @Test | ||
| public void basicMethods() { | ||
| assertTrue(provider.isAvailable()); |
There was a problem hiding this comment.
Yes, with the latest change made to UdsNettyChannelProvider it should be assumeTrue. Otherwise this was copied from NettyChannelProviderTest which used assertTrue . Good catch. Making the change
Fixed bazel build as well. PTAL |
When the scheme is "unix:" we get the UdsNettyChannelProvider to
create a NettyChannelBuilder with DomainSocketAddress type and
other related params needed for UDS sockets
fixes #8884