Merged
Conversation
Contributor
Author
|
Hi, Friendly ping @dapengzhang0 |
Member
|
Since the internal perfmark is not at 0.25.0 yet, I will do an import of perfmark first. If that works fine then I'll come back and merge this PR. |
ran-su
approved these changes
Mar 23, 2022
Member
|
It looks like this PR cannot be merged before bumping the google-cloud-logging version. |
Contributor
Author
|
@ran-su can you make that change? I'm uncertain how to make the necessary changes. |
Member
|
The process here is now much easier since #8238 . We no longer require all versions to be identical, but notice when Maven would downgrade a version. When that happens we just need to re-define the downgraded dependency higher in the dependency tree, or potentially just change the dependency order. Those are the normal steps to resolve requireUpperBoundDeps failures in Maven. |
temawi
pushed a commit
to temawi/grpc-java
that referenced
this pull request
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perfmark 0.24.0 is much more defensive about class initialization failures, and speeds up class load time by a few millis.