Skip to content

stub: Document StreamObserver is an async API#8449

Merged
ejona86 merged 2 commits intogrpc:masterfrom
ejona86:streamobserver-is-async
Aug 30, 2021
Merged

stub: Document StreamObserver is an async API#8449
ejona86 merged 2 commits intogrpc:masterfrom
ejona86:streamobserver-is-async

Conversation

@ejona86
Copy link
Copy Markdown
Member

@ejona86 ejona86 commented Aug 25, 2021

Missing docs were brought up in #8423

CC @morgwai

@ejona86 ejona86 requested a review from dapengzhang0 August 25, 2021 19:11
@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Aug 25, 2021

Hold up for a second. I'm going to add some more text.

@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Aug 30, 2021

@dapengzhang0, friendly ping

Comment thread stub/src/main/java/io/grpc/stub/ClientCallStreamObserver.java
Comment thread stub/src/main/java/io/grpc/stub/StreamObserver.java
Copy link
Copy Markdown
Contributor

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 5cc94a5 into grpc:master Aug 30, 2021
@ejona86 ejona86 deleted the streamobserver-is-async branch August 30, 2021 18:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants