Repository navigation
Conversation
veblush
marked this pull request as ready for review
October 24, 2024 22:52
Contributor
|
Change looks fine to me, @gnossen is there an official list of supported macOS versions for Python? |
Contributor
There isn't, though we probably should have one. Regardless, this change looks reasonable, given that our new floor will be a six year old Mac OS release. |
Contributor
|
@sourabhsinghs @sreenithi FYI, this will change the artifacts for the next release. |
gnossen
approved these changes
Oct 29, 2024
| # version Python was built on. You can further customize the target macOS | ||
| # version by setting the MACOSX_DEPLOYMENT_TARGET environment variable before | ||
| # running setup.py. | ||
| if sys.platform == "darwin": |
Contributor
Author
There was a problem hiding this comment.
Oh good catch. I added this to grpcio_observability/setup.py too
Contributor
There was a problem hiding this comment.
We don't need it since observability only support Linux for now, but it's fine to add it.
Contributor
Author
There was a problem hiding this comment.
Oh that's why I didn't see errors from grpcio_observability build. Thanks for the info.
XuanWang-Amos
approved these changes
Oct 29, 2024
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Nov 6, 2024
CPython uses this [logic](https://github.com/pypa/cibuildwheel/blob/b98602705f5449b8e221a1849a8dc18e8d8b14db/cibuildwheel/macos.py#L302-L323) to determine `MACOSX_DEPLOYMENT_TARGET` and the lowest possible value is `10.9` (Mavericks) as of today. But we need to use at least `10.14` (Mojave) to get prepared for upcoming C++17 upgrade (scheduled in 2024-11). This `10.14` version should be safe to use as i) Apple stopped supporting any versions older than 12.0 (https://endoflife.date/macos) and ii) this version is older than officially support OSX version (11.0) of gRPC Core/C++ (https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md) Closes grpc#37997 PiperOrigin-RevId: 691535457
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
CPython uses this [logic](https://github.com/pypa/cibuildwheel/blob/b98602705f5449b8e221a1849a8dc18e8d8b14db/cibuildwheel/macos.py#L302-L323) to determine `MACOSX_DEPLOYMENT_TARGET` and the lowest possible value is `10.9` (Mavericks) as of today. But we need to use at least `10.14` (Mojave) to get prepared for upcoming C++17 upgrade (scheduled in 2024-11). This `10.14` version should be safe to use as i) Apple stopped supporting any versions older than 12.0 (https://endoflife.date/macos) and ii) this version is older than officially support OSX version (11.0) of gRPC Core/C++ (https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md) Closes grpc#37997 PiperOrigin-RevId: 691535457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPython uses this logic to determine
MACOSX_DEPLOYMENT_TARGETand the lowest possible value is10.9(Mavericks) as of today. But we need to use at least10.14(Mojave) to get prepared for upcoming C++17 upgrade (scheduled in 2024-11). This10.14version should be safe to use as i) Apple stopped supporting any versions older than 12.0 (https://endoflife.date/macos) and ii) this version is older than officially support OSX version (11.0) of gRPC Core/C++ (https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md)