Fix compile-no-fork with existing jar FileSystems (#547)#548
Merged
fniephaus merged 1 commit intograalvm:masterfrom Jan 30, 2024
Merged
Fix compile-no-fork with existing jar FileSystems (#547)#548fniephaus merged 1 commit intograalvm:masterfrom
fniephaus merged 1 commit intograalvm:masterfrom
Conversation
FileSystems.newFileSystem on a dependency jar fails with a FileSystemAlreadyExistsException if another Maven plugin has already created it. Provide a wrapper that handles the exception, trying FileSystems.getFileSystem in that case.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
Contributor
Author
|
OCA signed. |
|
Thank you for signing the OCA. |
alvarosanchez
approved these changes
Jan 23, 2024
fniephaus
approved these changes
Jan 30, 2024
Member
fniephaus
left a comment
There was a problem hiding this comment.
LGTM, thanks for contributing!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSystems.newFileSystem on a dependency jar fails with a FileSystemAlreadyExistsException if another Maven plugin has already created it.
Provide a wrapper that handles the exception, trying FileSystems.getFileSystem in that case.