Skip to content

Reduce Time Required for Each Test Execution#531

Merged
dnestoro merged 2 commits intograalvm:masterfrom
dnestoro:dnestoro/ReduceTestingTime
Oct 27, 2023
Merged

Reduce Time Required for Each Test Execution#531
dnestoro merged 2 commits intograalvm:masterfrom
dnestoro:dnestoro/ReduceTestingTime

Conversation

@dnestoro
Copy link
Copy Markdown
Contributor

@dnestoro dnestoro commented Oct 23, 2023

This PR should update tests so that they run with -Ob flag

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 23, 2023
@dnestoro dnestoro self-assigned this Oct 23, 2023
@dnestoro dnestoro marked this pull request as draft October 23, 2023 13:05
@dnestoro dnestoro force-pushed the dnestoro/ReduceTestingTime branch from 259faf3 to a4180ec Compare October 26, 2023 15:57
@dnestoro dnestoro force-pushed the dnestoro/ReduceTestingTime branch from a4180ec to 9085b52 Compare October 26, 2023 15:58
@dnestoro dnestoro marked this pull request as ready for review October 26, 2023 19:44
@dnestoro dnestoro requested review from fniephaus and melix October 27, 2023 08:46
Copy link
Copy Markdown
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update the samples to remove -Ob, don't you?

@dnestoro
Copy link
Copy Markdown
Contributor Author

dnestoro commented Oct 27, 2023

@melix if I search for -Ob in the samples nothing is found. Is it possible that samples have some other option set that will force tests to run in -Ob mode that should be removed (if not than I can't find this flag in samples anywhere)?

Copy link
Copy Markdown
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnestoro dnestoro merged commit 87ca37d into graalvm:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants