Enable metadata copy when agent is enabled from cmd#407
Merged
dnestoro merged 3 commits intograalvm:masterfrom Mar 8, 2023
Merged
Conversation
alvarosanchez
requested changes
Feb 28, 2023
Member
alvarosanchez
left a comment
There was a problem hiding this comment.
This is not the way to fix the issue.
Instead, you need to use the property attribute of the @Parameter annotation in AgentConfiguration:
@Parameter(property = "agent")
private boolean enabled;Quoting their documentation:
Property to use to retrieve a value. Can come from
-Dexecution, setting properties or pom properties.
c1e7dae to
83f2ea3
Compare
alvarosanchez
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix this issue. Previously metadata-copy mojo didn't check if agent is enabled via command line