Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: retry reauth Authenticate if needed#1246

Merged
arithmetic1728 merged 3 commits intogoogleapis:mainfrom
cpisunyer:main
Mar 24, 2023
Merged

fix: retry reauth Authenticate if needed#1246
arithmetic1728 merged 3 commits intogoogleapis:mainfrom
cpisunyer:main

Conversation

@cpisunyer
Copy link
Copy Markdown
Contributor

Read both applicationId and relyingPartyId. If they are the same, use applicationId. If they are different, use relyingPartyId first and retry with applicationId.

cpisunyer and others added 2 commits March 10, 2023 15:22
If they are the same, use applicationId. If they
are different, first use relyingPartyId and retry with applicationId. This allows security
keys enrolled with both u2f and WebAuthN to work with the Reauth API.
@arithmetic1728 arithmetic1728 changed the title Retry reauth Authenticate if needed. fix: retry reauth Authenticate if needed Mar 10, 2023
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2023
@arithmetic1728 arithmetic1728 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 10, 2023
@arithmetic1728 arithmetic1728 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 23, 2023
@arithmetic1728 arithmetic1728 marked this pull request as ready for review March 23, 2023 23:43
@arithmetic1728 arithmetic1728 requested review from a team March 23, 2023 23:43
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2023
@arithmetic1728 arithmetic1728 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2023
@arithmetic1728 arithmetic1728 merged commit e125dfe into googleapis:main Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants