Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Do not use hardcoded string 'python', when you mean sys.executable.#1233

Merged
clundin25 merged 1 commit intogoogleapis:mainfrom
openSUSE-Python:no-python3
Feb 23, 2023
Merged

Do not use hardcoded string 'python', when you mean sys.executable.#1233
clundin25 merged 1 commit intogoogleapis:mainfrom
openSUSE-Python:no-python3

Conversation

@mcepl
Copy link
Copy Markdown
Contributor

@mcepl mcepl commented Feb 22, 2023

Perhaps fixes #1120

@mcepl mcepl requested review from a team February 22, 2023 19:59
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 22, 2023
@clundin25
Copy link
Copy Markdown
Contributor

Thank you for your contribution @mcepl !

Can you format your commit to fix: Do not use hardcoded string 'python', when you mean sys.executable to pass the conventional commits test?

@clundin25 clundin25 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 23, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 23, 2023
@clundin25
Copy link
Copy Markdown
Contributor

Hi @mcepl please pull in the latest changes in main for the tests to pass. Alternatively you can give me write permissions to your fork.

@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 23, 2023
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2023
@clundin25 clundin25 merged commit 91ac8e6 into googleapis:main Feb 23, 2023
@mcepl mcepl deleted the no-python3 branch February 24, 2023 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.11.0: pytest is failing

3 participants