Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: Remove 3PI config url validation#1220

Merged
BigTailWolf merged 7 commits intogoogleapis:mainfrom
BigTailWolf:b265844810
Feb 9, 2023
Merged

fix: Remove 3PI config url validation#1220
BigTailWolf merged 7 commits intogoogleapis:mainfrom
BigTailWolf:b265844810

Conversation

@BigTailWolf
Copy link
Copy Markdown
Contributor

Remove the url validation for TPC support.
Failed configuration will be on user's own risk in future.

@BigTailWolf BigTailWolf requested review from a team February 1, 2023 18:55
@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@clundin25
Copy link
Copy Markdown
Contributor

nit: Using the $ git revert $COMMIT could be an easier way to revert this code. This will also result in self-documenting commits.

@lsirac
Copy link
Copy Markdown
Contributor

lsirac commented Feb 1, 2023

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

@BigTailWolf
Copy link
Copy Markdown
Contributor Author

nit: Using the $ git revert $COMMIT could be an easier way to revert this code. This will also result in self-documenting commits.

I considered that. But I found those validations are not added the same time. And very hard to find all these separate changes.

@BigTailWolf
Copy link
Copy Markdown
Contributor Author

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

Hi @lsirac , and for the is_workforce_pool, we also have regex matching there, that would fail TPC user's check.

@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@lsirac
Copy link
Copy Markdown
Contributor

lsirac commented Feb 1, 2023

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

Hi @lsirac , and for the is_workforce_pool, we also have regex matching there, that would fail TPC user's check.

Yes, please update the regex as well

Let's keep it for now, and circle back on this

@BigTailWolf
Copy link
Copy Markdown
Contributor Author

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

Hi @lsirac , and for the is_workforce_pool, we also have regex matching there, that would fail TPC user's check.

Yes, please update the regex as well

Let's keep it for now, and circle back on this

Good. Maybe need backlog a "loose the pattern check for is_workforce_pool"

lsirac
lsirac previously approved these changes Feb 1, 2023
@lsirac lsirac dismissed their stale review February 2, 2023 04:56

docs missing

@BigTailWolf BigTailWolf requested a review from a team February 3, 2023 18:52
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
Comment thread docs/user-guide.rst Outdated
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@BigTailWolf
Copy link
Copy Markdown
Contributor Author

@arithmetic1728 may I get an approval?

Comment thread docs/user-guide.rst
Comment thread docs/user-guide.rst
@BigTailWolf BigTailWolf merged commit 8b95515 into googleapis:main Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants