This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: fix socket leak in impersonated_credentials#1123
Merged
clundin25 merged 2 commits intogoogleapis:mainfrom Aug 29, 2022
Merged
fix: fix socket leak in impersonated_credentials#1123clundin25 merged 2 commits intogoogleapis:mainfrom
clundin25 merged 2 commits intogoogleapis:mainfrom
Conversation
impersonated_credentials.Credentials.sign_bytes() created a session that wasn't closed leaking a socket. This fixes the issue by always closing the requests session after a signing request is complete. Fixes googleapis#1122
ac64264 to
2dcb6d3
Compare
Contributor
Author
|
The failing presubmit looks like nothing to do with my change https://source.cloud.google.com/results/invocations/29f9a2fd-8d3a-4251-88f0-4598f6910f6b/targets/github%2Fgoogle-auth-library-python%2Fsystem_tests/tests |
clundin25
approved these changes
Aug 29, 2022
Contributor
I've pushed a new test token to your branch. The tests will pass now. |
Contributor
Author
|
@clundin25 thanks, looks like everything is green now :) I don't have a merge button so I assume you'll merge this patch when you're ready? |
Contributor
|
@stewartmiles Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impersonated_credentials.Credentials.sign_bytes() created
a session that wasn't closed leaking a socket. This fixes
the issue by always closing the requests session after
a signing request is complete.
Fixes #1122