Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs(samples): add auth samples and tests#1102

Merged
Sita04 merged 30 commits intomainfrom
auth-samples
Aug 23, 2022
Merged

docs(samples): add auth samples and tests#1102
Sita04 merged 30 commits intomainfrom
auth-samples

Conversation

@Sita04
Copy link
Copy Markdown
Contributor

@Sita04 Sita04 commented Aug 8, 2022

No description provided.

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 8, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Aug 8, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

piaxc
piaxc reviewed Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown

@piaxc piaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Sita, thanks for the quick turnaround on these!

Comment thread samples/cloud-client/snippets/idtoken_from_impersonated_credentials.py Outdated
@Sita04 Sita04 marked this pull request as ready for review August 19, 2022 17:38
@Sita04 Sita04 requested a review from a team as a code owner August 19, 2022 17:38
@Sita04 Sita04 requested a review from parthea August 19, 2022 17:38
@gcf-owl-bot gcf-owl-bot Bot requested review from a team August 19, 2022 17:48
sai-sunder-s
sai-sunder-s approved these changes Aug 19, 2022
View reviewed changes
Comment thread samples/cloud-client/snippets/snippets_test.py Outdated
Comment thread samples/cloud-client/snippets/authenticate_explicit.py Outdated
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2022
@Sita04 Sita04 mentioned this pull request Aug 22, 2022
Closed
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 22, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 22, 2022
@sai-sunder-s sai-sunder-s added the owlbot:ignore instruct owl-bot to ignore a PR label Aug 22, 2022
@sai-sunder-s sai-sunder-s added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2022
@sai-sunder-s sai-sunder-s added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2022
@Sita04
Copy link
Copy Markdown
Contributor Author

Sita04 commented Aug 23, 2022

Thank you @sai-sunder-s and @parthea for the commits.
Merging this PR.

@Sita04 Sita04 merged commit ac87520 into main Aug 23, 2022
@Sita04 Sita04 deleted the auth-samples branch August 23, 2022 05:51
This was referenced Aug 23, 2022
Closed
Merged
@Sita04 Sita04 mentioned this pull request Aug 25, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

3 more reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@parthea parthea parthea approved these changes

@piaxc piaxc piaxc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sita04 @sai-sunder-s @parthea @piaxc @yoshi-kokoro