Fix fallback behavior of UnsafeReflectionAllocator when AccessibleObject isn't so accessible#1712
Merged
eamonnmcmanus merged 1 commit intogoogle:masterfrom Aug 4, 2021
Merged
Conversation
…ect isn't so accessible
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Marcono1234
reviewed
May 27, 2020
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Member
|
This looks reasonable. Thanks for the carefully-constructed test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm the lucky owner of a post-jigsaw Java platform that has restrictive security manager installed. Failing to catch the
SecurityExceptionthrown by a cross-classloadergetDeclaredFieldcall inUnsafeReflectionAllocator::getOverrideFieldprevents any Gson instances from being created.I'm hoping the fallback behavior in this class will be enough for us to use Gson without having to loosen our security policy.