Skip to content

Fix fallback behavior of UnsafeReflectionAllocator when AccessibleObject isn't so accessible#1712

Merged
eamonnmcmanus merged 1 commit intogoogle:masterfrom
rhernandez35:master
Aug 4, 2021
Merged

Fix fallback behavior of UnsafeReflectionAllocator when AccessibleObject isn't so accessible#1712
eamonnmcmanus merged 1 commit intogoogle:masterfrom
rhernandez35:master

Conversation

@rhernandez35
Copy link
Copy Markdown
Contributor

I'm the lucky owner of a post-jigsaw Java platform that has restrictive security manager installed. Failing to catch the SecurityException thrown by a cross-classloader getDeclaredField call in UnsafeReflectionAllocator::getOverrideField prevents any Gson instances from being created.

I'm hoping the fallback behavior in this class will be enough for us to use Gson without having to loosen our security policy.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rhernandez35
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@eamonnmcmanus
Copy link
Copy Markdown
Member

This looks reasonable. Thanks for the carefully-constructed test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants