Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.22.4
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.22.5
Choose a head ref
  • 15 commits
  • 41 files changed
  • 12 contributors

Commits on Jun 12, 2024

  1. [release-branch.go1.22] go/internal/gccgoimporter: recognize "any" as…

    … a builtin type
    
    In CL 536715 we're changing the gofrontend export data to report
    "any" as a builtin type. This permits us to distinguish the builtin
    type from some other package-level type "any". That requires an update
    to this code.
    
    Fixes #67850
    
    Change-Id: I91d75a056a155fa9892c4b25ab396cb4d39cc8e4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/537195
    Reviewed-by: Than McIntosh <thanm@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    (cherry picked from commit b8ac61e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592215
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    ianlancetaylor authored and gopherbot committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b515c52 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.22] net: add GODEBUG=netedns0=0 to disable sendin…

    …g EDNS0 header
    
    It reportedly breaks the DNS server on some modems.
    
    For #6464
    For #21160
    For #44135
    For #51127
    For #51153
    For #67925
    Fixes #67934
    
    Change-Id: I54a11906159f00246d08a54cc8be7327e9ebfd2c
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591995
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    (cherry picked from commit ee4a42b)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592217
    TryBot-Bypass: Ian Lance Taylor <iant@golang.org>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    ianlancetaylor authored and gopherbot committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fe9b3c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. [release-branch.go1.22] cmd/go: fix go list -u -m all with too new re…

    …tractions dependency
    
    Previously, go would not report retractions of dependencies that have a
    newer version of Go. With this change, we will still display retractions despite a version difference when go list -u -m is used.
    
    For: #66403
    Fixes: #68052
    
    Change-Id: I6406680235e294269836ae4cbe3d5680ca10eea0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/588775
    Auto-Submit: Sam Thanawalla <samthanawalla@google.com>
    Reviewed-by: Michael Matloob <matloob@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit e44fa1c)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/593355
    samthanawalla authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    179ccb7 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.22] cmd/link: put runtime.end in the last section…

    … of data segment
    
    Currently the runtime.end symbol is put into the noptrbss section,
    which is usually the last section, except that when fuzzing is
    enabled, the last section is actually .go.fuzzcntrs. The
    runtime.end symbol has the value pointing to the end of the data
    segment, so if it is not in the last section, the value will not
    actually be in the range of the section. This causes an assertion
    failure in the new Apple linker. This CL fixes this by putting it
    in the last section.
    
    Updates #65169.
    Fixes #67945.
    
    Change-Id: I5c991c46a0483a96e5f6e0255a3b444953676026
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592095
    Reviewed-by: Than McIntosh <thanm@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit b589478)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592478
    cherrymui authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4c97e88 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.22] cmd/cgo/internal/testsanitizers: make the lib…

    …fuzzer tests all short
    
    CL 589295 only made one of the two tests short, because the other one
    seemed to be passing consistently in short mode. On the builders, it
    seems to still fail maybe 30% of the time by taking too long. Disable
    these tests in short mode.
    
    This CL was merged with CL 589295 before cherry-picking.
    
    For #67698.
    Fixes #67715.
    
    Change-Id: I9fd047f834f7493b608dd1fee5b9b6dfabbea03d
    Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15,go1.22-linux-386-clang15
    Reviewed-on: https://go-review.googlesource.com/c/go/+/589495
    Auto-Submit: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Commit-Queue: Michael Knyszek <mknyszek@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591376
    mknyszek authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ab60a7b View commit details
    Browse the repository at this point in the history
  4. [release-branch.go1.22] cmd/cgo/internal/swig: force use of lld for L…

    …TO tests on the builders
    
    For whatever reason, on the builders, when using /usr/bin/ld (the
    default linker) with -flto we end up with problems. Specifically, the
    linker seems to require LLVMgold.so and can't find it. I'm not really
    sure why, but what definitely seems to work is forcing use of lld, which
    ships with our clang installation on the builders.
    
    Just enforce this on the builders for now; I've actually had very few
    problems running this locally (and I think I'm also mixing and matching
    linkers and toolchains too...), so it may be related to the version of
    clang we're testing with.
    
    For #67698.
    For #67715.
    
    Change-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20
    Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15,go1.22-linux-386-clang15
    Reviewed-on: https://go-review.googlesource.com/c/go/+/589296
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591375
    mknyszek authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    14f0251 View commit details
    Browse the repository at this point in the history
  5. [release-branch.go1.22] crypto/tls: don't call tlsrsakex.IncNonDefaul…

    …t with FIPS
    
    We haven't called tlsrsakex.Value() yet at this point if we're using
    FIPS, like if CipherSuites != nil. This adds needFIPS as a gate next to
    CipherSuites != nil. FIPS specifies suites that would be skipped if
    tlsarsakex were set.
    
    For #65991.
    Fixes #65994.
    
    Change-Id: I8070d8f43f27c04067490af8cc7ec5e787f2b9bd
    Reviewed-on: https://go-review.googlesource.com/c/go/+/582315
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    TryBot-Bypass: Filippo Valsorda <filippo@golang.org>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    (cherry picked from commit 78e50d0)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/593395
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    michaelbeaumont authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    81fc616 View commit details
    Browse the repository at this point in the history
  6. [release-branch.go1.22] go/types, types2: report error for floating-p…

    …oint iteration variable
    
    While at it, slightly improve documentation and code.
    Also, add additional test cases for #66561.
    
    Updates #66561.
    Fixes #67798.
    
    Change-Id: I682b0e9227e065d6bbd199871c2e1ecff13edc66
    Reviewed-on: https://go-review.googlesource.com/c/go/+/580937
    Reviewed-by: Robert Griesemer <gri@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Robert Findley <rfindley@google.com>
    Auto-Submit: Robert Griesemer <gri@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/590056
    griesemer authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    11b861e View commit details
    Browse the repository at this point in the history
  7. [release-branch.go1.22] cmd/compile: put constants before variables i…

    …n initialization order
    
    Fixes #67820.
    
    Change-Id: I03f4d4577b88ad0a92b260b2efd0cb9fe5082b2f
    Reviewed-on: https://go-review.googlesource.com/c/go/+/575075
    Reviewed-by: Robert Griesemer <gri@google.com>
    Reviewed-by: Keith Randall <khr@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/590395
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: Keith Randall <khr@golang.org>
    randall77 authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5159a71 View commit details
    Browse the repository at this point in the history
  8. [release-branch.go1.22] runtime: always update stack bounds on cgocal…

    …lback
    
    callbackUpdateSystemStack contains a fast path to exit early without
    update if SP is already within the g0.stack bounds.
    
    This is not safe, as a subsequent call may have new stack bounds that
    only partially overlap the old stack bounds. In this case it is possible
    to see an SP that is in the old stack bounds, but very close to the
    bottom of the bounds due to the partial overlap. In that case we're very
    likely to "run out" of space on the system stack.
    
    We only need to do this on extra Ms, as normal Ms have precise bounds
    defined when we allocated the stack.
    
    TSAN annotations are added to x_cgo_getstackbounds because bounds is a
    pointer into the Go stack. The stack can be reused when an old thread
    exits and a new thread starts, but TSAN can't see the synchronization
    there. This isn't a new case, but we are now calling more often.
    
    For #62440.
    Fixes #67298.
    
    Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-longtest
    Change-Id: I5389050494987b7668d0b317fb92f85e61d798ac
    Reviewed-on: https://go-review.googlesource.com/c/go/+/584597
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit 1ffc296)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/585935
    Run-TryBot: Joedian Reid <joedian@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    prattmic authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3560cf0 View commit details
    Browse the repository at this point in the history
  9. [release-branch.go1.22] os/exec: on Windows look for extensions in Ru…

    …n if not already done
    
    CL 512155 fixed #36768, but introduced #62596.
    CL 527820 fixed #62596, but meant that the code failed to look up
    file extensions on Windows for a relative path.
    This CL fixes that problem by recording whether it has already
    looked up file extensions.
    This does mean that if Path is set manually then we do not update
    it with file extensions, as doing that would be racy.
    
    For #66586
    Fixes #66598
    
    Change-Id: I9a0305d1e466c5e07bfbe442566ea12f5255a96e
    GitHub-Last-Rev: dc3169f
    GitHub-Pull-Request: #67035
    Reviewed-on: https://go-review.googlesource.com/c/go/+/581695
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    (cherry picked from commit 5532427)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/594495
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    qiulaidongfeng authored and gopherbot committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    dfe4dbf View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. [release-branch.go1.22] cmd/compile: mark pointer to noalg type as noalg

    When the compiler writes PtrToThis field of noalg type, it generates
    its pointer type. Mark them as noalg to prevent put them in typelinks.
    
    Fixes #65983
    
    Change-Id: Icbc3b18bc866f9138c7648e42dd500a80326f72b
    Reviewed-on: https://go-review.googlesource.com/c/go/+/567335
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    Auto-Submit: Keith Randall <khr@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Keith Randall <khr@google.com>
    (cherry picked from commit b8c76ef)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/593876
    Reviewed-by: David Chase <drchase@google.com>
    wdvxdr1123 authored and joedian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ceaf26e View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.22] net/http: send body or close connection on ex…

    …pect-100-continue requests
    
    When sending a request with an "Expect: 100-continue" header,
    we must send the request body before sending any further requests
    on the connection.
    
    When receiving a non-1xx response to an "Expect: 100-continue" request,
    send the request body if the connection isn't being closed after
    processing the response. In other words, if either the request
    or response contains a "Connection: close" header, then skip sending
    the request body (because the connection will not be used for
    further requests), but otherwise send it.
    
    Correct a comment on the server-side Expect: 100-continue handling
    that implied sending the request body is optional. It isn't.
    
    For #67555
    Fixes #68200
    
    Change-Id: Ia2f12091bee697771087f32ac347509ec5922d54
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591255
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Jonathan Amsterdam <jba@google.com>
    (cherry picked from commit cf501e0)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/595235
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Joedian Reid <joedian@google.com>
    neild authored and joedian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3222951 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.22] cmd/link: handle dynamic import variables on …

    …Darwin in plugin mode
    
    CL 501855 added support for cgo_dynamic_import variables on Darwin.
    But it didn't support the plugin build mode on amd64, where the
    assembler turns a direct load (R_PCREL) to a load via GOT
    (R_GOTPCREL). This CL adds the support. We just need to handle
    external linking mode, as this can only occur in plugin or shared
    build mode, which requires external linking.
    
    Fixes #68122.
    Updates #67976.
    Updates #50891.
    
    Change-Id: I0f56265d50bfcb36047fa5538ad7a5ec77e7ef96
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592499
    Reviewed-by: David Chase <drchase@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit 44f1870)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/595175
    Reviewed-by: Joedian Reid <joedian@google.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    cherrymui authored and joedian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c2d4f85 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. [release-branch.go1.22] go1.22.5

    Change-Id: Ibc28cd85275c5a1c943b0d052b6adc4425ab5165
    Reviewed-on: https://go-review.googlesource.com/c/go/+/596255
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: David Chase <drchase@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Than McIntosh <thanm@google.com>
    gopherbot committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8e1fdea View commit details
    Browse the repository at this point in the history
Loading