Skip to content

Standalone mode - #119

Merged
crazy-max merged 2 commits into
docker:masterfrom
crazy-max:standalone
Apr 26, 2022
Merged

Standalone mode#119
crazy-max merged 2 commits into
docker:masterfrom
crazy-max:standalone

Conversation

@crazy-max

@crazy-max crazy-max commented Dec 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

In in the future we might want to use buildx in standalone mode.

Also display buildx version being used as suggested in docker/buildx#850 (comment)

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max
crazy-max force-pushed the standalone branch 8 times, most recently from 6058310 to 9e2adc3 Compare December 17, 2021 12:56
@crazy-max
crazy-max marked this pull request as ready for review December 17, 2021 12:58
@crazy-max
crazy-max force-pushed the standalone branch 2 times, most recently from e6bc7b7 to ab9657c Compare December 17, 2021 13:04
@crazy-max
crazy-max requested a review from tonistiigi December 17, 2021 13:06
@crazy-max crazy-max mentioned this pull request Apr 11, 2022
Closed
@crazy-max
crazy-max force-pushed the standalone branch 2 times, most recently from ee201e2 to 718663d Compare April 12, 2022 11:57
tonistiigi
tonistiigi reviewed Apr 12, 2022
View reviewed changes

@tonistiigi tonistiigi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more docs? I'm not sure what standalone mode means and what cases I would want to use it.

@crazy-max
crazy-max force-pushed the standalone branch 3 times, most recently from e2b514f to 8e47826 Compare April 12, 2022 21:30
@crazy-max

crazy-max commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

@tonistiigi Added a section in the README about this use case and also a job in our ci workflow to check this behavior: https://github.com/docker/setup-buildx-action/runs/5997903516?check_suite_focus=true

Docker info
  Docker info skipped in standalone mode
Download and install buildx
  Downloading https://github.com/docker/buildx/releases/download/v0.8.2/buildx-v0.8.2.linux-amd64
  Standalone mode
  Fixing perms
  Added buildx to the path
Buildx version
  /tmp/docker-setup-buildx-sUFOIL/bin/buildx version
  github.com/docker/buildx v0.8.2 6224def4dd2c3d347eee19db595348c50d7cb491
Creating a new builder instance
  /tmp/docker-setup-buildx-sUFOIL/bin/buildx create --name builder-cc4b69f7-2699-433a-9998-687962319ba0 --driver kubernetes --buildkitd-flags --allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host --use
  builder-cc4b69f7-2699-433a-9998-687962319ba0
Booting builder
  /tmp/docker-setup-buildx-sUFOIL/bin/buildx inspect --bootstrap --builder builder-cc4b69f7-2699-433a-9998-687962319ba0
  #1 [internal] booting buildkit
  #1 waiting for 1 pods to be ready
  #1 waiting for 1 pods to be ready 10.4s done
  #1 DONE 10.5s
  Name:   builder-cc4b69f7-2699-433a-9998-687962319ba0
  Driver: kubernetes
  
  Nodes:
  Name:      builder-cc4b69f7-2699-433a-9998-687962319ba00-59f548fdf-msdbr
  Endpoint:  
  Status:    running
  Platforms: linux/amd64, linux/amd64/v2, linux/amd64/v3, linux/386
Inspect builder
  {
    "name": "builder-cc4b69f7-2699-433a-9998-687962319ba0",
    "driver": "kubernetes",
    "node_name": "builder-cc4b69f7-2699-433a-9998-687962319ba00-59f548fdf-msdbr",
    "node_status": "running",
    "node_platforms": "linux/amd64,linux/amd64/v2,linux/amd64/v3,linux/386"
  }

@crazy-max
crazy-max requested a review from tonistiigi April 12, 2022 21:36
tonistiigi
tonistiigi reviewed Apr 13, 2022
View reviewed changes

@tonistiigi tonistiigi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a point in making it configurable or should it just be an automatic fallback if there is no docker or accessing docker buildx fails while buildx binary exists?

Comment thread README.md Outdated
### Standalone mode

If you don't have the Docker engine and CLI installed on your GitHub Runner,
you can use buildx in standalone mode. This can be useful if you want to use

@tonistiigi tonistiigi Apr 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add "mode. In this case buildx binary is invoked directly, instead of calling it as a docker plugin."

@crazy-max

crazy-max commented Apr 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Is there a point in making it configurable or should it just be an automatic fallback if there is no docker or accessing docker buildx fails while buildx binary exists?

Good point, I guess we can do that.

@crazy-max
crazy-max force-pushed the standalone branch 3 times, most recently from 0b02f3b to a656177 Compare April 17, 2022 15:14
@crazy-max
support standalone mode and display version
3472856 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
ci: add jobs to check standalone behavior
17ebdd4 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
crazy-max requested a review from tonistiigi April 17, 2022 15:34
tonistiigi
tonistiigi approved these changes Apr 26, 2022
View reviewed changes

@tonistiigi tonistiigi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the build-push action support the same thing?

@crazy-max

crazy-max commented Apr 26, 2022

Copy link
Copy Markdown
Member Author

Does the build-push action support the same thing?

Not yet, will work on it.

@crazy-max
crazy-max merged commit 7117987 into docker:master Apr 26, 2022
@crazy-max
crazy-max deleted the standalone branch April 26, 2022 12:16
@crazy-max crazy-max mentioned this pull request Apr 27, 2022
Merged
@crazy-max crazy-max mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crazy-max @tonistiigi