Add ability to verify claim presence#442
Merged
jimmyjames merged 5 commits intomasterfrom Sep 24, 2020
Merged
Conversation
lbalmaceda
previously approved these changes
Sep 24, 2020
lbalmaceda
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As raised in #360, we should provide the ability to verify a claim's presence, regardless of value.
This change adds a new
Verificationmethod,withClaimPresence(String name). It will throw anInvalidClaimExceptionif the JWT does not contain the specified claim.This change does not add the ability to verify a claim is present and of a specific type. That may be a feature we wish to add at some point, but we'd need to consider how best to surface that without exposing any of Jackson's node types. Such a change wouldn't impact the new method added in this PR, so we can still provide value here with the new presence check method.
References
#360
Testing
Checklist