feat(core): add equality function to rxjs-interop toSignal#56447
Closed
alxhub wants to merge 1 commit intoangular:mainfrom
Closed
feat(core): add equality function to rxjs-interop toSignal#56447alxhub wants to merge 1 commit intoangular:mainfrom
toSignal#56447alxhub wants to merge 1 commit intoangular:mainfrom
Conversation
`toSignal` predates the decision to allow a more flexible equality check in signals, and thus doesn't support a custom equality function. This commit adds the ability to pass a custom value equality function. As a side effect, it now adds the default equality check where it wasn't used before. Fixes angular#55573
pkozlowski-opensource
approved these changes
Jun 14, 2024
pkozlowski-opensource
approved these changes
Jun 14, 2024
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
thePunderWoman
approved these changes
Jun 14, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
dylhunn
approved these changes
Jun 14, 2024
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 5df3e78. The changes were merged into the following branches: main |
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toSignalpredates the decision to allow a more flexible equality check in signals, and thus doesn't support a custom equality function. This commit adds the ability to pass a custom value equality function. As a side effect, it now adds the default equality check where it wasn't used before.Fixes #55573