Skip to content

feat(compiler): Add extended diagnostic to warn when there are uncall…#56295

Closed
eneajaho wants to merge 1 commit intoangular:mainfrom
eneajaho:feat/fn-call-extended
Closed

feat(compiler): Add extended diagnostic to warn when there are uncall…#56295
eneajaho wants to merge 1 commit intoangular:mainfrom
eneajaho:feat/fn-call-extended

Conversation

@eneajaho
Copy link
Copy Markdown
Contributor

@eneajaho eneajaho commented Jun 5, 2024 •
edited
Loading

…ed functions in event bindings

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Issue Number: #56293

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from JoostK June 6, 2024 00:00
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 6, 2024
JeanMeche
JeanMeche reviewed Jun 6, 2024
View reviewed changes
Comment thread packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts Outdated
@eneajaho eneajaho force-pushed the feat/fn-call-extended branch from 7984b73 to 96f8cf7 Compare June 6, 2024 10:08
@eneajaho eneajaho changed the title wip - feat(compiler): Add extended diagnostic to warn when there are uncall… feat(compiler): Add extended diagnostic to warn when there are uncall… Jun 6, 2024
@eneajaho eneajaho force-pushed the feat/fn-call-extended branch 2 times, most recently from 4ab103e to 5f29588 Compare June 7, 2024 13:17
@JeanMeche JeanMeche mentioned this pull request Jun 12, 2024
Closed
@JeanMeche JeanMeche requested review from alxhub and devversion June 12, 2024 19:12
devversion
devversion reviewed Jun 13, 2024
View reviewed changes
Comment thread ...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts Outdated
Comment thread ...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts Outdated
Comment thread ...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts Outdated
Comment thread ...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts Outdated
@eneajaho eneajaho requested review from JeanMeche and devversion June 13, 2024 11:52
@eneajaho eneajaho force-pushed the feat/fn-call-extended branch 2 times, most recently from b71b2ff to a05d143 Compare June 13, 2024 11:53
devversion
devversion approved these changes Jun 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@pullapprove pullapprove bot requested review from atscott and thePunderWoman June 17, 2024 06:42
@eneajaho eneajaho force-pushed the feat/fn-call-extended branch from a05d143 to f7871a3 Compare June 17, 2024 08:15
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Jun 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 17, 2024
@eneajaho eneajaho force-pushed the feat/fn-call-extended branch from f7871a3 to 8adf83a Compare June 17, 2024 08:19
thePunderWoman
thePunderWoman approved these changes Jun 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from AndrewKushnir June 18, 2024 13:56
@JeanMeche JeanMeche mentioned this pull request Jun 24, 2024
Closed
JoostK
JoostK reviewed Jun 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a documentation page!

Comment thread ...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts Outdated
Comment thread ...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts Outdated
@eneajaho eneajaho force-pushed the feat/fn-call-extended branch from 8adf83a to 1fb4811 Compare June 28, 2024 20:11
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 28, 2024
@eneajaho eneajaho force-pushed the feat/fn-call-extended branch from 1fff002 to 86bf4cf Compare June 28, 2024 20:31
@angular-robot angular-robot bot added detected: feature PR contains a feature commit labels Jul 2, 2024
@eneajaho
Copy link
Copy Markdown
Contributor Author

eneajaho commented Jul 2, 2024

@eneajaho I cannot since the rebase includes the revert. You'll need to cherry pick the commit and re-push.

Done

@thePunderWoman thePunderWoman added the requires: TGP This PR requires a passing TGP before merging is allowed label Jul 2, 2024
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Jul 2, 2024
@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker and removed action: discuss action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: global presubmit The PR is in need of a google3 global presubmit labels Jul 2, 2024
@thePunderWoman thePunderWoman removed the request for review from alxhub July 3, 2024 15:32
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Jul 3, 2024

This PR was merged into the repository by commit c8e2885.

The changes were merged into the following branches: main

@saxenakshitiz saxenakshitiz mentioned this pull request Jul 31, 2024
Closed
@mightysai1997 mightysai1997 mentioned this pull request Jul 31, 2024
Open
@Saptaasur Saptaasur mentioned this pull request Jul 31, 2024
Open
@cvalverd cvalverd mentioned this pull request Aug 1, 2024
Open
@gipo355 gipo355 mentioned this pull request Aug 1, 2024
Open
@SaulReyes-ux SaulReyes-ux mentioned this pull request Aug 1, 2024
Open
@ambrose40 ambrose40 mentioned this pull request Aug 1, 2024
Open
@beyerleinf beyerleinf mentioned this pull request Aug 1, 2024
Open
@sixcorners sixcorners mentioned this pull request Aug 1, 2024
Closed
@surajpuvvada surajpuvvada mentioned this pull request Aug 2, 2024
Closed
@brstlk brstlk mentioned this pull request Aug 2, 2024
Open
@josuedeleonaguilar josuedeleonaguilar mentioned this pull request Aug 2, 2024
Open
@amarhusain amarhusain mentioned this pull request Aug 2, 2024
Open
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Aug 3, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@JoostK JoostK JoostK approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@alxhub alxhub alxhub approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: compiler Issues related to `ngc`, Angular's template compiler detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

6 participants

@eneajaho @thePunderWoman @JoostK @JeanMeche @alxhub @devversion