fix(compiler-cli): avoid emitting references to typecheck files in TS 5.4 (#56961)

crisbeto · atscott · commit c94a8972488f · 2024-07-15T11:22:00.000-07:00
In #56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references. These changes add tagging right before the program emits. Fixes #56945. PR Close #56961
diff --git a/packages/compiler-cli/src/ngtsc/program.ts b/packages/compiler-cli/src/ngtsc/program.ts
@@ -293,6 +293,10 @@ export class NgtscProgram implements api.Program {
       }
     }
 
+    // Untag all the files, otherwise TS 5.4 may end up emitting
+    // references to typecheck files (see #56945).
+    untagAllTsFiles(this.tsProgram);
+
     const forceEmit = opts?.forceEmit ?? false;
 
     this.compiler.perfRecorder.memory(PerfCheckpoint.PreEmit);

Original file line number	Diff line number	Diff line change
`@@ -293,6 +293,10 @@ export class NgtscProgram implements api.Program {`
`293`	`293`	`}`
`294`	`294`	`}`
`295`	`295`
	`296`	`+ // Untag all the files, otherwise TS 5.4 may end up emitting`
	`297`	`+ // references to typecheck files (see #56945).`
	`298`	`+ untagAllTsFiles(this.tsProgram);`
	`299`	`+`
`296`	`300`	`const forceEmit = opts?.forceEmit ?? false;`
`297`	`301`
`298`	`302`	`this.compiler.perfRecorder.memory(PerfCheckpoint.PreEmit);`