Shadow jackson deps and remove deprecations#615
Merged
Merged
Conversation
eroshenkoam
approved these changes
Jul 5, 2021
This was referenced Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #609
Currently
allure-modeldepends on Jackson internally to ensure proper JSON (de)serialisation of Allure results. The proposed change removes this dependency and make it so now users will need to configure object mapper to read Allure results.And in order to make it works we are now forced to do some breaking model changes (but the good news is that all the changes is basically removal of already deprecated code).
Jackson dependency is now shaded to
allure-java-commonsmodule with package replace.