Back out the workaround and force dependency in our BOM#1059
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
meltsufin
approved these changes
Apr 8, 2022
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the workaround directly in Spring Cloud GCP binder, the
spring-cloud-gcp-starter-bus-pubsuband its sample applications still pick up the bad version ofspring-cloud-function-contextfrom the Spring Cloud Stream dependency tree.Forcing dependency in the Spring Cloud GCP BOM seems to be the only way to make sure Spring Cloud GCP users who follow our documentation get the correct version of Spring Cloud Function.