fix: row column indexing in SpannerClientLibraryRow#615
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
meltsufin
commented
Dec 14, 2022
|
|
||
| @Override | ||
| public boolean isNew() { | ||
| return true; |
Member
Author
There was a problem hiding this comment.
This is to help Spring Data to know that this is a new object during repository.save() even though the ID is not null.
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <skip.surefire.tests>${skipTests}</skip.surefire.tests> |
Member
Author
There was a problem hiding this comment.
I believe this is redundant and it is breaking IntelliJ. So, removing.
Contributor
There was a problem hiding this comment.
They also looks redundant to me, but it seems to be explicitly added by #329, not sure if reason still relevant?
zhumin8
approved these changes
Dec 16, 2022
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <skip.surefire.tests>${skipTests}</skip.surefire.tests> |
Contributor
There was a problem hiding this comment.
They also looks redundant to me, but it seems to be explicitly added by #329, not sure if reason still relevant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #609