Skip to content

Commit 15fd56b

Browse files
Matt Loringbnoordhuis
authored andcommitted
Enable V8 deprecation warnings for native modules
It will be helpful for native module developers to be aware of any deprecated apis they are using so that they can update before their modules break completely. Module developers can override this option in their binding.gyp if they do not want to see these warnings. PR-URL: #920 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 7f1c1b9 commit 15fd56b

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

addon.gypi

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
'<(node_root_dir)/deps/v8/include'
1212
],
1313
'defines': [
14-
'NODE_GYP_MODULE_NAME=>(_target_name)'
14+
'NODE_GYP_MODULE_NAME=>(_target_name)',
15+
# Warn when using deprecated V8 APIs.
16+
'V8_DEPRECATION_WARNINGS=1'
1517
],
1618

1719
'target_conditions': [

0 commit comments

Comments
 (0)