move mutateFS reset out of t.teardown

isaacs · isaacs · commit 8cd81396b8a0 · 2023-05-12T14:37:36.000-07:00
Not sure why this was failing on my system, but this fixes it.
diff --git a/test/unpack.js b/test/unpack.js
@@ -514,7 +514,8 @@ t.test('symlink in dir path', {
 
   t.test('clobber through symlink with busted unlink', t => {
     const poop = new Error('poop')
-    t.teardown(mutateFS.fail('unlink', poop))
+    // for some reason, resetting fs.unlink in the teardown was breaking
+    const reset = mutateFS.fail('unlink', poop)
     const warnings = []
     const u = new Unpack({
       cwd: dir,
@@ -523,6 +524,7 @@ t.test('symlink in dir path', {
     })
     u.on('close', _ => {
       t.same(warnings, [['TAR_ENTRY_ERROR', 'poop', poop]])
+      reset()
       t.end()
     })
     u.end(data)
