Repository navigation
Added support for reduced accuracy detection on iOS 14 - #1739
Gerald Versluis (jfversluis) merged 7 commits into
Conversation
James Montemagno (jamesmontemagno)
left a comment
There was a problem hiding this comment.
I think beyond my feedback seems fine. XML docs need to be updated, but besides that is good.
|
James Montemagno (@jamesmontemagno) I've adjusted the version check to use the DeviceInfo API as suggested |
|
James Montemagno (@jamesmontemagno) The suggested changes have been applied |
48398ac
Co-authored-by: James Montemagno <james.montemagno@gmail.com>
e6776a7 to
96b69b4
Compare
|
Not sure if we should still pull this in for Xamarin.Essentials since it's adding APIs but at the same time it also supports newer iOS functionalities. THoughts James Montemagno (@jamesmontemagno) ? |
|
I'm relatively fine with it if we do a 1.8.0 |
|
James Montemagno (@jamesmontemagno) Gerald Versluis (@jfversluis) |
|
Mina Girgis Shenouda (@mina5500) this is not merged, so unfortunately not. |
Gerald Versluis (jfversluis)
left a comment
There was a problem hiding this comment.
Looks like this exact code is running in .NET MAUI without too many problems and we have updated Xamarin.Essentials with another major version, so let's do it.
Description of Change
iOS 14 added the ability for users to grant location permission with reduced accuracy.
In such cases the requested accuracy is ignored and the coarse location is returned.
This PR adds:
Platform notes:
ReducedAccuracyproperty always returns false on non-iOS platformsNSLocationTemporaryUsageDescriptionDictionaryin the app's plist file. The keyXamarinEssentialsFullAccuracyUsageDescriptionwas used for this purpose.Bugs Fixed
API Changes
Added:
bool Location.ReducedAccuracy { get; set; }bool GeolocationRequest.RequestFullAccuracy { get; set; }PR Checklist
mainat time of PR