Skip to content

fix(routing): rewrite regression#13634

Merged
ematipico merged 1 commit intomainfrom
fix/regression-rewrite-base
Apr 16, 2025
Merged

fix(routing): rewrite regression#13634
ematipico merged 1 commit intomainfrom
fix/regression-rewrite-base

Conversation

@ematipico
Copy link
Copy Markdown
Member

Changes

Closes #13633

A check was modified, but it turns out that it was required, in fact the tests introduced in #13598 still pass

Testing

Added a new test case

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: c230eff

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Apr 16, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 16, 2025

CodSpeed Performance Report

Merging #13634 will not alter performance

Comparing fix/regression-rewrite-base (c230eff) with main (99af0d1)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico merged commit 516de7d into main Apr 16, 2025
17 checks passed
@ematipico ematipico deleted the fix/regression-rewrite-base branch April 16, 2025 13:10
@astrobot-houston astrobot-houston mentioned this pull request Apr 16, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Co-authored-by: florian-lefebvre <69633530+florian-lefebvre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5.7.0 trailingSlash changes breaks rewriting

2 participants