fix(@astrojs/rss): revert incorrect Content-Type header applied for RSS XML file#12829
Merged
ematipico merged 2 commits intowithastro:mainfrom Dec 26, 2024
SapphoSys:fix-rss
Merged
fix(@astrojs/rss): revert incorrect Content-Type header applied for RSS XML file#12829ematipico merged 2 commits intowithastro:mainfrom SapphoSys:fix-rss
ematipico merged 2 commits intowithastro:mainfrom
SapphoSys:fix-rss
Conversation
1 task
ematipico
approved these changes
Dec 26, 2024
Merged
|
While the fix works for most browsers, it breaks iOS Safari support, which, I think, was the main motive behind #12644. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This fixes an issue where the RSS XML file generated by
@astrojs/rssis displayed in plaintext due to a faultyContent-Typeheader by reverting the #12644 pull request.For more information, you can view the #12828 issue that I filed.
Example screenshots
Before (current,
Content-Typeheader is set toapplication/rss+xml; charset=utf-8sinceastro@5.0.3)After (manually overriding the
Content-Typeheader toapplication/xmlwhich was the value used by@astrojs/rssbefore the PR change)Testing
A reproducible example can be found here: https://codesandbox.io/p/devbox/kind-hugle-27v5l?on=codesandbox
Or, if you want to reproduce it yourself:
/rss.xmlRSS XML pageYou should see the XML page being displayed in plaintext.
Reproducible example screenshot for the "Blog" Template in CodeSandbox