Skip to content

feat(sitemap): add xslURL to enable styling#11485

Merged
ematipico merged 5 commits intowithastro:mainfrom
sondr3:sitemap-xsl
Oct 3, 2024
Merged

feat(sitemap): add xslURL to enable styling#11485
ematipico merged 5 commits intowithastro:mainfrom
sondr3:sitemap-xsl

Conversation

@sondr3
Copy link
Copy Markdown
Contributor

@sondr3 sondr3 commented Jul 17, 2024

Changes

Add a xslURL option to the sitemap generator to enable styling of the generated sitemap(s).

Testing

I haven't added tests yet as I didn't know whether to add a new unit test or create a new fixture, so figured I could create the PR and gather feedback.

Docs

withastro/docs#8840

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: f1b4f08

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label Jul 17, 2024
Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing, I am not really sure how we can test it other than manual testing.

Comment thread packages/integrations/sitemap/src/index.ts
@matthewp
Copy link
Copy Markdown
Contributor

Sounds good to me. A fixture test is what I'd do.

@florian-lefebvre
Copy link
Copy Markdown
Member

@sondr3 are you still interested in this PR?

@sondr3
Copy link
Copy Markdown
Contributor Author

sondr3 commented Aug 26, 2024

Sorry, didn't realize that action was needed on my end 😅 I'll get to writing a test

@florian-lefebvre
Copy link
Copy Markdown
Member

@sondr3 are you still interested in this PR?

@florian-lefebvre florian-lefebvre added the needs response Issue needs response from OP label Sep 23, 2024
@florian-lefebvre
Copy link
Copy Markdown
Member

Closing due to inactivity, if you'd like to keep working on this, please re-open.

@sondr3
Copy link
Copy Markdown
Contributor Author

sondr3 commented Sep 27, 2024

Yeah, sorry, started a new job and got a puppy so have been low on time. I'll reopen when I have time again 😃

@bluwy bluwy reopened this Sep 30, 2024
Comment thread .changeset/proud-horses-cry.md Outdated
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@florian-lefebvre florian-lefebvre removed the needs response Issue needs response from OP label Sep 30, 2024
Comment thread packages/integrations/sitemap/src/index.ts
@ematipico
Copy link
Copy Markdown
Member

The code seems to be approved, but the docs aren't approved yet. Let's wait to merge the PR

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs!

@ematipico ematipico merged commit fbe1bc5 into withastro:main Oct 3, 2024
@astrobot-houston astrobot-houston mentioned this pull request Oct 3, 2024
@sondr3 sondr3 deleted the sitemap-xsl branch October 3, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants