Skip to content

chore: logging cleanup#11263

Merged
bluwy merged 1 commit intowithastro:mainfrom
wackbyte:logging-cleanup
Jun 17, 2024
Merged

chore: logging cleanup#11263
bluwy merged 1 commit intowithastro:mainfrom
wackbyte:logging-cleanup

Conversation

@wackbyte
Copy link
Copy Markdown
Contributor

Changes

  • Use the logger provided by Astro more consistently in integrations.
  • Remove an old duplicate check in the sitemap integration.

Testing

No tests added because there are no integration log tests (to my knowledge).

Docs

No docs added because this is strictly stylistic.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 453df97

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label Jun 14, 2024
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset (patch)? You can get one by running pnpm changeset from the root

Comment thread packages/integrations/sitemap/src/index.ts
Comment thread .changeset/thin-icons-yell.md Outdated
Use the logger provided by Astro more consistently in integrations and
remove an old duplicate check in the sitemap integration.
@bluwy bluwy merged commit 7d59750 into withastro:main Jun 17, 2024
@astrobot-houston astrobot-houston mentioned this pull request Jun 17, 2024
@wackbyte wackbyte deleted the logging-cleanup branch June 17, 2024 08:31
ematipico pushed a commit that referenced this pull request Feb 5, 2025
ematipico pushed a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants