Skip to content

fix(useSpeechRecognition): send correct transcript result#3891

Merged
antfu merged 2 commits intovueuse:mainfrom
noook:fix/speech
May 28, 2024
Merged

fix(useSpeechRecognition): send correct transcript result#3891
antfu merged 2 commits intovueuse:mainfrom
noook:fix/speech

Conversation

@noook
Copy link
Copy Markdown
Contributor

@noook noook commented Mar 26, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Fixes #3890

WebSpeechRecognition results differ on mobile and desktop. This PR handles the result on both platforms.

Additional context

Tested on mobile and desktop.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 26, 2024
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 28, 2024
@antfu antfu added this pull request to the merge queue May 28, 2024
Merged via the queue into vueuse:main with commit 7c36fe5 May 28, 2024
@Soresu
Copy link
Copy Markdown

Soresu commented Jun 18, 2024 •
edited
Loading

After this PR, I cannot use useSpeechRecognition as I used before. It always clear the result, even if i change interimResults or continuous to a different value.

let { result, start, stop, isListening, toggle } = useSpeechRecognition({
  lang: 'en-US',
  interimResults: true,
  continuous: true,
});

Test sentence: I slowly speak, so I will see that it keeps the whole sentence.
Desktop, Chrome 125.0.6422.142

The result with 10.9.0:

 I 
 I slowly 
 I slowly speak
 I slowly speak, so 
 I slowly speak, so I 
 I slowly speak, so I will 
 I slowly speak, so I will sea
 I slowly speak, so I will see that
 I slowly speak, so I will see that it
 I slowly speak, so I will see that it keeps
 I slowly speak, so I will see that it keeps the
 I slowly speak, so I will see that it keeps the whole
 I slowly speak, so I will see that it keeps the whole sentence

The result with 10.11.0:

 I 
 I slowly 
 I slowly speak
 so 
 so I 
 so I will 
 see that
...

This was referenced Jul 3, 2024
Open
Open
This was referenced Jul 24, 2024
Open
Open
@Samad2011s Samad2011s mentioned this pull request Jul 28, 2024
Open
@noook noook deleted the fix/speech branch August 16, 2024 09:12
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 30, 2024
Open
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Speech recognition concatenates multiple results and gives wrong output

3 participants

@noook @Soresu @antfu