packages/reactivity/src/collectionHandlers.ts (1)

56-73: LGTM: iterator wrapper now preserves iterator instance/prototype methods while still wrapping yielded values.
The Object.create(innerIterator) + override next() approach should fix the reported loss of iterator methods after values()/keys()/entries() while keeping innerIterator.next() as the source of truth.

Add a regression test for “iterator methods preserved” without relying on runtime Iterator Helpers.
Consider a unit test that temporarily augments Object.getPrototypeOf(rawMap.values()) with a sentinel method (restore afterward), then asserts reactive(map).values() exposes it and still yields wrapped values.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Learnt from: naramdash
Repo: vuejs/core PR: 14058
File: packages/reactivity/src/collectionHandlers.ts:252-271
Timestamp: 2025-11-05T14:53:01.052Z
Learning: In Vue's reactivity system, collection methods that create new collections (like Array's slice(), concat(), filter() and Set's difference(), intersection(), union(), symmetricDifference()) intentionally return raw (non-reactive) collections, not reactive proxies. This is by design - only the values/elements inside can remain reactive if they were originally reactive.

packages/reactivity/__tests__/collections/Map.spec.ts (1)

475-498: LGTM! Test comprehensively validates iterator property inheritance.

The test correctly validates that the wrapped iterator preserves the prototype chain from the raw iterator, including both named properties and symbols. The checks for next, Symbol.iterator, and the iterable protocol (line 485) are all appropriate.

📋 Optional: Consider testing other iterator methods

While .entries() is tested here, you might also want to verify .values() and .keys() iterators inherit properties correctly, since the original issue #12615 specifically mentioned .values():

// Additional test cases
const valuesIterator = map.values()
expect(typeof valuesIterator.next).toBe('function')
expect(typeof valuesIterator[Symbol.iterator]).toBe('function')

const keysIterator = map.keys()
expect(typeof keysIterator.next).toBe('function')
expect(typeof keysIterator[Symbol.iterator]).toBe('function')

This would provide more comprehensive coverage of all iterator methods affected by the fix.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Learnt from: naramdash
Repo: vuejs/core PR: 14058
File: packages/reactivity/src/collectionHandlers.ts:252-271
Timestamp: 2025-11-05T14:53:01.052Z
Learning: In Vue's reactivity system, collection methods that create new collections (like Array's slice(), concat(), filter() and Set's difference(), intersection(), union(), symmetricDifference()) intentionally return raw (non-reactive) collections, not reactive proxies. This is by design - only the values/elements inside can remain reactive if they were originally reactive.